Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update typescript compiler target to ES2023 #1991

Merged

Conversation

romainbrancourt
Copy link
Contributor

@romainbrancourt romainbrancourt commented Feb 6, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Since NestJS 11 now requires Node.js v20 or higher, Typescript compiler target can be set to ES2023 safely.
(https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping)

This enables usage of new features such as:

  • Error cause property
  • Array functions: at, findLast, findLastIndex, toSorted...
  • Object.hasOwn function
    etc...

Does this PR introduce a breaking change?

  • Yes
  • No

@romainbrancourt romainbrancourt changed the title chore: update typescript compiler target to ES2022 chore: update typescript compiler target to ES2023 Feb 6, 2025
@romainbrancourt romainbrancourt force-pushed the update-ts-compiler-target branch from 2a5b4c9 to 83f92d0 Compare February 6, 2025 13:14
Copy link
Member

@micalevisk micalevisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please update https://github.com/nestjs/typescript-starter/ as well?

@kamilmysliwiec kamilmysliwiec merged commit 0afab32 into nestjs:master Feb 17, 2025
1 check passed
@kamilmysliwiec
Copy link
Member

LGTM

@romainbrancourt
Copy link
Contributor Author

could you please update https://github.com/nestjs/typescript-starter/ as well?

nestjs/typescript-starter#321

@romainbrancourt romainbrancourt deleted the update-ts-compiler-target branch February 20, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants