Adding Netbird GitHub Link to the Client UI About Sub Menu

[robertgro]

Describe your changes

Adding Netbird GitHub Link to the Client UI About Sub Menu

Issue ticket number and link

Checklist

• Is it a bug fix
• Is a typo/documentation fix
• Is a feature enhancement
• It is a refactor
• Created tests that fail without the change (if possible)
• Extended the README / documentation, if necessary

Mandatory in my opinion. You are free to decline/reject this PR if you like or if it isn't qualified (a reason would be nice then). Thanks anyway for the efforts guys.

[CLAassistant]

All committers have signed the CLA.

[robertgro]

Quality Gate failed

Failed conditions 1 New issue 9.52% Technical Debt Ratio on New Code (required ≤ 5%) 1 New Code Smells (required ≤ 0) B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

The issue here is that "This function has 104 lines of code, which is greater than the 100 authorized. Split it into smaller functions."

In my opinion, it would be a disproportionate expense to split and refactor this due to the limit. Either you have some space to ignore this limitation and approve the PR. On the other hand, it is understandable for me if this doesn't get merged into main (due to it shouldn't be that high of a priority to add such a link). Thx anyway as I said.

[sonarqubecloud]

Quality Gate failed

Failed conditions
1 New issue
B Maintainability Rating on New Code (required ≥ A)
9.52% Technical Debt Ratio on New Code (required ≤ 5%)
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[robertgro]

I gotta admit, it's rather a proposal than an actual implementation (was done on the fly). Feel free to alter the few lines of code as you like.

The lint issues have been corrected as well as the spacing in my editor.

For the line limitation of 100 lines in the func onTrayReady() https://github.com/netbirdio/netbird/blob/main/client/ui/client_ui.go#L576

you could consider to outsource the setup of the system tray menu items in https://github.com/netbirdio/netbird/blob/main/client/ui/client_ui.go#L580 due to by the time passing, you eventually would hit the limit anyways as the application begins to grow and more and more menu items are added.

This is a common software engineering pattern that is been found in frameworks like ASP.NET Core or Framework (compare Microsoft's dotnet approach in one of their project templates https://github.com/dotnet/templating/wiki/Available-templates-for-dotnet-new).

I'll leave this decision to your hands.