[client] Add missing client meta flags #3898
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing client meta flags to ensure that new connection settings—namely LAN blocking, inbound blocking, and lazy connection—are properly propagated throughout the client and server communication.
- Added three new boolean flags (blockLANAccess, blockInbound, lazyConnectionEnabled) to the proto message and updated client code to use them.
- Updated all relevant client components (grpc, system info, login, engine, connect) to support and pass the new flags.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| management/proto/management.proto | Added new boolean flags with incremental tag numbers in the Flags message. |
| management/client/grpc.go | Mapped new flags from the Info struct to the proto PeerSystemMeta. |
| client/system/info.go | Updated the Info struct and SetFlags to include the new flags. |
| client/internal/login.go | Updated login and peer registration calls to pass the new flags. |
| client/internal/engine.go | Updated engine functions to include the new flags in meta synchronization. |
| client/internal/connect.go | Updated connect function to pass new flags during login. |
Comments suppressed due to low confidence (2)
client/system/info.go:76
- [nitpick] The SetFlags function now takes many parameters; consider refactoring to accept a configuration struct to improve readability and maintainability.
func (i *Info) SetFlags(
client/internal/engine.go:786
- [nitpick] With the repeated passing of configuration booleans across multiple functions, consider encapsulating these flags into a dedicated meta struct to reduce redundancy and simplify method signatures.
e.config.DisableServerRoutes,
There was a problem hiding this comment.
Pull Request Overview
This PR adds three new client meta flags to support finer-grained controls over network behavior. The changes include adding new proto fields in Flags, propagating these flags in client metadata, and updating the corresponding functions across various client components.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| management/proto/management.proto | Added new protobuf fields: BlockLANAccess, BlockInbound, LazyConnectionEnabled to Flags |
| management/client/grpc.go | Updated meta conversion to include the new flags |
| client/system/info.go | Extended Info struct and its SetFlags method with new flags |
| client/internal/login.go | Updated mgm login and registration calls with new flag support |
| client/internal/engine.go | Propagated new flags in engine updates and management synchronization calls |
| client/internal/connect.go | Extended login function to pass along new flags |
|
Describe your changes
Issue ticket number and link
Stack
Checklist