netbox_ip_address: support for FHRP group assignment #1429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc68cal
reviewed
Jun 19, 2025
| @@ -1076,6 +1076,11 @@ def _build_query_params( | |||
| query_dict.update( | |||
| {"interface_id": module_data.get("assigned_object_id")} | |||
| ) | |||
| elif module_data["assigned_object_type"] == "ipam.fhrpgroup": | |||
| query_dict.update( | |||
| {"???": module_data.get("assigned_object_id")} | |||
There was a problem hiding this comment.
I'm just guessing here but it might be group_id or group. It's hard to tell, looking at https://github.com/netbox-community/netbox/blob/c660f1c019ddb46713f830c360dd5804784c73df/netbox/ipam/api/serializers_/fhrpgroups.py#L5.
Virtual Chassis uses master which is defined here - https://github.com/netbox-community/netbox/blob/main/netbox/dcim/api/serializers_/virtualchassis.py#L12 so that's the pattern I'm using to guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#1428
New Behavior
Add support for FHRP group assignment
...
Contrast to Current Behavior
doesnt support it rn
...
Discussion: Benefits and Drawbacks
just a draft PR right now,
I'm trying to read into the codebase to understand how exactly the query_dict is relevant and how it does the assignment to assigned_object
...
Changes to the Documentation
n/a \ in code
...
Proposed Release Note Entry
netbox_ip_address: add support for FHRP group assignment
...
Double Check
develbranch.