fix: revert guard removal made in 9cb2744 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 9cb2744, I made a change that removed a guard that was seemingly unnecessary. This guard is a bug, but I misunderstood the code and introduced a new, worse bug.
✅ Deploy Preview for csp-integration ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ndhoule
commented
Oct 14, 2024
| // FIXME(ndhoule): This is a bug. At one point we added a default value for config, which | ||
| // means we can no longer enter this case. | ||
| // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition | ||
| if (!config) { |
There was a problem hiding this comment.
The bug here is: we default config to {} where it's defined, so this condition is impossible. But I spaced and made the CSP extension always use the default config. 😶
(I have a branch that will fix various issues in the CSP extension and add some tests, so I'll add a regression test for this.)
YujohnNattrass
approved these changes
Oct 14, 2024
ndhoule
added a commit
that referenced
this pull request
Oct 21, 2024
ndhoule
added a commit
that referenced
this pull request
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 9cb2744, I made a change that removed a guard that was seemingly unnecessary. This guard is a bug, but I misunderstood the code and introduced a new, worse bug.