Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: includeKeys when fetching pointer #129

Closed
wants to merge 1 commit into from

Conversation

project-saf
Copy link

@project-saf project-saf commented Sep 7, 2023

New Pull Request Checklist

Issue Description

This is a bug fix for the fetch(includeKeys...) function in Pointer.
Related discussion

Approach

Account for the params.

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #129 (2a57cce) into main (5f2c5f4) will decrease coverage by 0.16%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   91.35%   91.19%   -0.16%     
==========================================
  Files         175      175              
  Lines       15457    15417      -40     
==========================================
- Hits        14121    14060      -61     
- Misses       1336     1357      +21     
Files Changed Coverage Δ
...urces/ParseSwift/API/API+NonParseBodyCommand.swift 80.00% <0.00%> (ø)
Sources/ParseSwift/Coding/ParseCoding.swift 90.90% <ø> (-2.60%) ⬇️
Sources/ParseSwift/Types/Pointer.swift 98.14% <91.66%> (-1.86%) ⬇️

... and 7 files with indirect coverage changes

@@ -115,13 +115,20 @@
Task {
var options = options
options.insert(.cachePolicy(.reloadIgnoringLocalCacheData))

Check warning

Code scanning / Swiftlint (reported by Codacy)

Lines should not have trailing whitespace. Warning

Lines should not have trailing whitespace.
@@ -115,13 +115,20 @@
Task {
var options = options
options.insert(.cachePolicy(.reloadIgnoringLocalCacheData))

Check warning

Code scanning / Tailor (reported by Codacy)

Line should not have any trailing whitespace Warning

Line should not have any trailing whitespace
@cbaker6
Copy link
Member

cbaker6 commented Sep 7, 2023

Thanks for submitting a PR for the issue. Be sure to install SwiftLint following the directions here to fix the CI issues https://github.com/netreconlab/Parse-Swift/blob/main/CONTRIBUTING.md#environment-setup

@cbaker6
Copy link
Member

cbaker6 commented Sep 18, 2023

In the future, when you create a PR, please check the box to give me access to make changes to the repo.

Closing this in favor of #133 since I don't have access to fix linting

@cbaker6 cbaker6 closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants