Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template: fortinet_get_system_interface_physical #2033

Merged

Conversation

yone2ks
Copy link
Contributor

@yone2ks yone2ks commented Feb 20, 2025

ISSUE TYPE

Update Template

COMPONENT

fortinet_get_system_interface_physical.textfsm, .*, fortinet, g[[et]] sy[[stem]] in[[terface]] p[[hysical]]

SUMMARY

Support for FortiOS version 7.4.0
FortiOS version 7.4.0 add the FEC and FEC_cap line , so updated to support them.

CHANGES

Update template to correctly parse both cases where FEC/FEC_cap are present or absent,
but FEC/FEC_cap aren't recorded to maintain backward compatibility with older FortiOS versions.

@mjbear
Copy link
Collaborator

mjbear commented Feb 21, 2025

resolves #2032

Copy link
Collaborator

@mjbear mjbear Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yone2ks
I noticed all of the FEC and FEC_cap in this PR's test data are none.

Could you modify your device so you can provide some test output that includes more (if not all) possible values (for FEC/FEC_cap)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, FEC cannot be enabled in my environment.
a high-performance physical device is required to enable FEC, and I tried to find the command output on the web but could not find it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, FEC cannot be enabled in my environment. a high-performance physical device is required to enable FEC, and I tried to find the command output on the web but could not find it.

😮‍💨 I've already done the work, but ...

Why are we capturing FEC/FEC_cap if you cannot enable it and thus it likely doesn't provide value. Right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjbear
Thank you for your help.

I believe you are referring to #2032 .
(This template does not currently retrieve the values for FEC/FEC_cap.)
I think it's better to capture them in case someone finds them useful. That's why I asked—although I don’t have a clear idea myself, I thought there might be an easy way that someone else is familiar with.

@jvanderaa jvanderaa merged commit 7a633d6 into networktocode:master Feb 25, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants