-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Text Generation][V2] NonKVCachePipeline #1483
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… router and image classification pipeline/operators/example (#1325) * initial functionality and working example with image classification * remove testing image * update args * initial functionality and working example with image classification * remove testing image * pr comments * defines schemas for operators and test * add image classification test, PR comments * fix input/output handling in pipeline and operator base classes to be more generic; remove context * add additional operator input message * typo fix
* [v2] EngineOperator updates to make continuous batching easier * test fixes
…ity (#1348) * initial functionality and working example with image classification * remove testing image * rebase fixes * initial functionality and working example with image classification * text gen * updates func * prompt inference, initial functionality * remove image; update state docstring * Fix typo * add todo for split/join * remove context, clean-up args, remove prefill_preprocess_operaator * fix docstrings
…generation functionality (#1356) * initial functionality and working example with image classification * remove testing image * rebase fixes * initial functionality and working example with image classification * text gen * updates func * prompt inference, initial functionality * remove image; update state docstring * Fix typo * add todo for split/join * remove context, clean-up args, remove prefill_preprocess_operaator * fix docstrings * initial functionality and working example with image classification * updates func * prompt inference, initial functionality * finish generation operators and update routes * further breakdown operators * add operators * fix can_operate condition * update can_operate to not rely on the inference_state * rebase + update * fix condition * fix capacity settting again * typo fixes
…e code to remove repeat code, update map function
…eature/damian/v2/factor_out_transformation_utils
…scope of fixtures module to help with speed
…eature/damian/v2/factor_out_transformation_utils
* unit testing for text generation operators * additional changes * unit testing completion * remove debug * fix * add todo * more clean-up * fix test * add docstrings/comments * break out tests to individual unit test files; add conftest and make scope of fixtures module to help with speed * fix name
…ng and prioritization (#1373) * [Continuous Batching] Queue Implementation to support batching grouping and prioritization * has_key method * thread safety * add blocking option for pop_batch * update docstring * allow mutex to be shared across continuous batching objects * revert last commit
…#1374) * [Continuous Batching] Executor thread for running continuous batching * quality * ensure that executor stops when main thread does - clean up test hack
* [ContinuousBatching] ContinuousBatchingScheduler Implementation * cleanup unnecessary stop condition
* [continuous batching] singleton pattern for scheduler * catch from review
dbogunowicz
commented
Dec 18, 2023
dbogunowicz
changed the title
Feature/damian/no kv cache retrieve
[Text Generation][V2] NonKVCachePipeline
Dec 18, 2023
bfineran
previously approved these changes
Dec 18, 2023
dsikka
requested changes
Dec 19, 2023
src/deepsparse/transformers/pipelines/text_generation/generate_new_token.py
Outdated
Show resolved
Hide resolved
src/deepsparse/transformers/pipelines/text_generation/prep_for_generation.py
Outdated
Show resolved
Hide resolved
src/deepsparse/transformers/pipelines/text_generation/pipeline_no_kv_cache.py
Show resolved
Hide resolved
dbogunowicz
commented
Dec 20, 2023
src/deepsparse/transformers/pipelines/text_generation/pipeline_no_kv_cache.py
Show resolved
Hide resolved
bfineran
approved these changes
Dec 29, 2023
dsikka
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes - this looks great.
I think the only thing that we're missing is the logic check which runs the appropriate pipeline by checking if kv_cache is present. We should do this in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Description
Added the
TestGenerationPipelineNoKVCache
. This pipeline processes the prompt and returns the new token. That's it.Its main functionality is mapping prompt tokens to logits, instrumental for computing the perplexity of the model given a dataset
Testing
Updated the integration tests to cover the case of non-kv-cache inference.
Example Use
Next steps
TextGenerationPipeline
operator that can either choose to use the kv-cache or non-kv cache version of the pipeline, depending on the topology of the ONNX modelTextGenerationPipelineNoKVCache