[nri-bundle] Adding ebpf agent to nri bundle. #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pbeckwith <[email protected]>
Signed-off-by: pbeckwith <[email protected]>
Signed-off-by: pbeckwith <[email protected]>
Signed-off-by: pbeckwith <[email protected]>
Signed-off-by: pbeckwith <[email protected]>
Signed-off-by: pbeckwith <[email protected]>
Signed-off-by: pbeckwith <[email protected]>
Signed-off-by: pbeckwith <[email protected]>
Signed-off-by: pbeckwith <[email protected]>
Signed-off-by: pbeckwith <[email protected]>
Signed-off-by: pbeckwith <[email protected]>
Signed-off-by: pbeckwith <[email protected]>
Philip-R-Beckwith
force-pushed
the
pbeckwith/add-ebpf
branch
from
703af52
to
3054826
Compare
… pbeckwith/add-ebpf
Signed-off-by: pbeckwith <[email protected]>
Philip-R-Beckwith
changed the title
kpattaswamy
reviewed
Nov 7, 2024
charts/nri-bundle/README.md.gotmpl
Outdated
| @@ -26,6 +26,7 @@ here is a list of components that this chart installs and where you can find mor | |||
| | [newrelic-prometheus-configurator](https://github.com/newrelic/newrelic-prometheus-configurator/tree/master/charts/newrelic-prometheus-agent) | | Configures instances of Prometheus in Agent mode to send metrics to the New Relic Prometheus endpoint. | | |||
| | [newrelic-pixie](https://github.com/newrelic/helm-charts/tree/master/charts/newrelic-pixie) | | Connects to the Pixie API and enables the New Relic plugin in Pixie. The plugin allows you to export data from Pixie to New Relic for long-term data retention. | | |||
| | [Pixie](https://docs.pixielabs.ai/installing-pixie/install-schemes/helm/#3.-deploy) | | Is an open source observability tool for Kubernetes applications that uses eBPF to automatically capture telemetry data without the need for manual instrumentation. | | |||
| | [newrelic-pixie](https://github.com/newrelic/helm-charts/tree/master/charts/newrelic-pixie) | | Configures instances of the New Relic eBPF agent to automatically capture telemetry data without the need for manual instrumentation. | | |||
There was a problem hiding this comment.
Suggested change
| | [newrelic-pixie](https://github.com/newrelic/helm-charts/tree/master/charts/newrelic-pixie) | | Configures instances of the New Relic eBPF agent to automatically capture telemetry data without the need for manual instrumentation. | | |
| | [nr-ebpf-agent](https://github.com/newrelic/helm-charts/tree/master/charts/nr-ebpf-agent) | | Configures instances of the New Relic eBPF agent to automatically capture telemetry data without the need for manual instrumentation. | |
There was a problem hiding this comment.
Good eyes. 👍
kpattaswamy
reviewed
Nov 7, 2024
charts/nri-bundle/README.md
Outdated
| @@ -25,6 +25,7 @@ here is a list of components that this chart installs and where you can find mor | |||
| | [newrelic-prometheus-configurator](https://github.com/newrelic/newrelic-prometheus-configurator/tree/master/charts/newrelic-prometheus-agent) | | Configures instances of Prometheus in Agent mode to send metrics to the New Relic Prometheus endpoint. | | |||
| | [newrelic-pixie](https://github.com/newrelic/helm-charts/tree/master/charts/newrelic-pixie) | | Connects to the Pixie API and enables the New Relic plugin in Pixie. The plugin allows you to export data from Pixie to New Relic for long-term data retention. | | |||
| | [Pixie](https://docs.pixielabs.ai/installing-pixie/install-schemes/helm/#3.-deploy) | | Is an open source observability tool for Kubernetes applications that uses eBPF to automatically capture telemetry data without the need for manual instrumentation. | | |||
| | [nr-ebpf-agent](https://docs.pixielabs.ai/installing-pixie/install-schemes/helm/#3.-deploy) | | Configures instances of the New Relic eBPF agent to automatically capture telemetry data without the need for manual instrumentation. | | |||
There was a problem hiding this comment.
Will need to change the link to eBPF agent here.
There was a problem hiding this comment.
👍 Good catch.
Signed-off-by: pbeckwith <[email protected]>
kpattaswamy
previously approved these changes
Nov 7, 2024
| @@ -26,6 +26,9 @@ dependencies: | |||
| - name: newrelic-pixie | |||
| repository: https://newrelic.github.io/helm-charts | |||
| version: 2.1.6 | |||
| - name: nr-ebpf-agent | |||
| repository: https://newrelic.github.io/helm-charts | |||
| version: 0.1.10 | |||
There was a problem hiding this comment.
Let's update it to 0.1.12?
| @@ -65,6 +66,11 @@ dependencies: | |||
| condition: newrelic-pixie.enabled | |||
| version: 2.1.6 | |||
|
|
|||
| - name: nr-ebpf-agent | |||
| version: 0.1.10 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart
No.
What this PR does / why we need it:
Allows users to install the eBPF agent chart through the Nri bundle chart.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
N/A
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname])