Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(agent): drupal code formatting #1029

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

bduranleau-nr
Copy link
Contributor

No description provided.

@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Feb 24, 2025

Test Suite Status Result
Multiverse 8/8 passing
SOAK 79/79 passing

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.58%. Comparing base (11b67fa) to head (1654b33).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1029   +/-   ##
=======================================
  Coverage   77.58%   77.58%           
=======================================
  Files         198      198           
  Lines       27715    27715           
=======================================
  Hits        21503    21503           
  Misses       6212     6212           
Flag Coverage Δ
agent-for-php-7.2 77.72% <0.00%> (ø)
agent-for-php-7.3 77.74% <0.00%> (ø)
agent-for-php-7.4 77.45% <0.00%> (ø)
agent-for-php-8.0 76.84% <100.00%> (ø)
agent-for-php-8.1 77.34% <100.00%> (ø)
agent-for-php-8.2 76.95% <75.00%> (ø)
agent-for-php-8.3 76.95% <75.00%> (ø)
agent-for-php-8.4 76.97% <75.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're at it, could you add clang-format off/on protection around these lines so that they don't break mid-word on auto-format:

NR_PSTR("Symfony\\Component\\HttpKernel\\EventListe"
"ner\\RouterListener::onKernelRequest"),

nr_php_wrap_user_function(NR_PSTR("Symfony\\Component\\HttpKernel\\EventListe"
"ner\\RouterListener::onKernelRequest"),

nr_php_wrap_user_function(NR_PSTR("Drupal\\Core\\Controller\\ControllerResolv"
"er::getControllerFromDefinition"),

@lavarou lavarou changed the title chore(agent): drupal code formatting style(agent): drupal code formatting Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants