refactor(agent): expose trace id and span id with app metadata #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor/security-agent-support #933 +/- ##
===================================================================
- Coverage 77.27% 77.24% -0.04%
===================================================================
Files 199 199
Lines 27785 27797 +12
===================================================================
Hits 21472 21472
- Misses 6313 6325 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ZNeumann
reviewed
Jul 10, 2024
| is_allocated = true; | ||
| break; | ||
| case NR_PHP_CSEC_METADATA_SPAN_ID: | ||
| id_value = nr_txn_get_current_span_id(NRPRG(txn)); |
There was a problem hiding this comment.
The span id will be different depending on which agent's instrumentation is called first with OAPI
bduranleau-nr
added
the
on hold
|
@ZNeumann @lavarou @bduranleau-nr
|
This was referenced Jan 24, 2025
anmol-ap
force-pushed
the
refactor/security-agent-support
branch
from
a5afe89 to
587a75d
Compare
anmol-ap
force-pushed
the
add/refactor/security-agent-support
branch
from
ec678aa to
fb5fd97
Compare
|
Rebased the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with other app metadata, expose trace id and span id as well