Skip to content

Conversation

lrafeei
Copy link
Contributor

@lrafeei lrafeei commented Aug 18, 2025

This PR is a fix for this issue: #1076

The issue noted above can also be resolved if the Python version used has been released after Jan 31, 2025. For future reference, this is the last version of urllib.parse that will cause New Relic's Python agent to crash due to an invalid IP address (such as the one formatted in issue #1076): https://github.com/python/cpython/blob/f3266c05b6186ab6d1db0799c06b8f76aefe7cf1/Lib/urllib/parse.py

@lrafeei lrafeei linked an issue Aug 18, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Aug 18, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 6 0 0 0.77s
✅ MARKDOWN markdownlint 7 0 0 0 1.24s
✅ MARKDOWN markdown-link-check 7 0 0 16.12s
✅ PYTHON ruff 922 0 0 0 0.92s
✅ PYTHON ruff-format 922 0 0 0 0.29s
✅ YAML prettier 13 0 0 0 1.45s
✅ YAML v8r 13 0 0 6.49s
✅ YAML yamllint 13 0 0 0.67s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@mergify mergify bot added the tests-failing Tests failing in CI. label Aug 18, 2025
@mergify mergify bot removed the tests-failing Tests failing in CI. label Aug 18, 2025
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.33%. Comparing base (e7c4c02) to head (d8caba3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
newrelic/api/web_transaction.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1449   +/-   ##
=======================================
  Coverage   81.33%   81.33%           
=======================================
  Files         208      208           
  Lines       23586    23589    +3     
  Branches     3720     3720           
=======================================
+ Hits        19183    19187    +4     
  Misses       3145     3145           
+ Partials     1258     1257    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lrafeei lrafeei marked this pull request as ready for review August 19, 2025 21:32
@lrafeei lrafeei requested a review from a team as a code owner August 19, 2025 21:32
@mergify mergify bot added the tests-failing Tests failing in CI. label Aug 25, 2025
@lrafeei lrafeei enabled auto-merge (squash) August 26, 2025 19:12
@lrafeei lrafeei merged commit 2995261 into main Aug 26, 2025
60 checks passed
@lrafeei lrafeei deleted the malformed-requests-exception branch August 26, 2025 19:31
@mergify mergify bot removed the tests-failing Tests failing in CI. label Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception when invalid IP address
3 participants