BugFix - Use File ID Instead of File Object for EditorWebView Argument Passing #14960
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes argument-passing logic to use the fileId (a Long) instead of the full
OCFile
object when navigating toEditorWebView
and its subclasses.Currently,
RichDocumentsEditorWebView
andTextEditorWebView
extends fromEditorWebView
, which itself extends fromExternalSiteWebView
, and it is also extends fromFileActivity
. Due to this inheritance chain, theonCreate
methods of parent classes are executed before those of the child. As a result, any largeOCFile
object passed through an Intent will crash beforeFileActivity
has the chance to handle it properly.This issue arises because Android imposes a 1MB limit on Parcelable extras.
This PR resolves that by passing only the fileId, which is later used to retrieve the
OCFile
withinFileActivity
.How to test?