Skip to content

fix deletion of folder content in DB #15023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Jun 18, 2025

  • Tests written, or not not needed

@tobiasKaminsky tobiasKaminsky changed the title fix deletion of folder in DB fix deletion of folder content in DB Jun 18, 2025
@tobiasKaminsky tobiasKaminsky force-pushed the createTopFolderOnUpload branch from 27dad13 to 8e982fd Compare June 18, 2025 06:31
@tobiasKaminsky
Copy link
Member Author

/backport to stable-3.32

Signed-off-by: tobiasKaminsky <[email protected]>
@tobiasKaminsky tobiasKaminsky force-pushed the createTopFolderOnUpload branch from 8e982fd to 5ca15fd Compare June 20, 2025 05:48
Copy link

test-Unit test failed, but no output was generated. Maybe a preliminary stage failed.

}

@Test
public void deleteOnlyParentFolder() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment

@@ -468,7 +468,11 @@ private Cursor query(SupportSQLiteDatabase db,
// add ID to arguments if Uri has more than one segment
if (uriMatch != ROOT_DIRECTORY && uri.getPathSegments().size() > SINGLE_PATH_SEGMENT) {
String idColumn = uriMatch == DIRECTORY ? ProviderTableMeta.FILE_PARENT : ProviderTableMeta._ID;
selection = idColumn + "=? AND " + selection;
if (TextUtils.isEmpty(selection)) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explain it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant