-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adjust styles for Nextcloud 30 (default heading styles) #1184
Conversation
I am wondering, are the server styles not applied here? Because maintaining these styles in all places sounds very demanding to me... |
They are, but we need to adjust, as our h3 here e.g. for cards would be too big. |
I see. then lets do it like that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should also change the styles on server again to not use the h1 styles for h2 ... but just use h2 for h2 etc. |
Fyi @nextcloud/designers |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Should this get in @susnux? |
we need to do so, probably adjusting the size a bit more |
0788bfc
to
9cf211b
Compare
@susnux if it is an improvement over the current state than I'd say let's merge as-is and have a follow-up. If it doesn't improve the situation in the current state of the PR, than let's leave it open for now. |
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@AndyScherzinger yes we need this otherwise it does not properly fit Nextcloud 30 |
/compile amend/ |
Signed-off-by: Ferdinand Thiessen <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
0efa446
to
fdfcb90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
Thanks @susnux - merged. I think daily pulls master-branch also for this app. Hence we can look at it tomorrow 👍 |
Adjusted the headings for https://github.com/nextcloud/server/pull/43640/files