feat: close modal on send #10976
Open
feat: close modal on send #10976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
GretaD
force-pushed
the
feat/close-modal-onsend
branch
from
4881d82 to
1010763
Compare
Signed-off-by: greta <[email protected]>
ChristophWurst
requested changes
Apr 25, 2025
There was a problem hiding this comment.
the modal should close instantly and the sending or saving to the outbox should happen in the background
This is not happening. The modal stays open until the message is added to the outbox. Until then, the modal stays editable (!), which appears as if the Send button didn't react.
Signed-off-by: greta <[email protected]>
st3iny
approved these changes
May 5, 2025
ChristophWurst
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10721