Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings): accept settings URL from discovery endpoint #4521

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(settings): accept settings URL from discovery endpoint #4521

wants to merge 1 commit into from
+27 −15

Conversation

codewithvk
Copy link
Collaborator

@codewithvk codewithvk commented Feb 25, 2025 •
edited
Loading

  • Resolves: #
  • Target version: main

Summary

TODO

  • Handle case when we don't send setting discovery endpoint

juliusknorr
juliusknorr reviewed Feb 25, 2025
View reviewed changes
@codewithvk codewithvk force-pushed the private/codewithvk/url_issue branch from b6d360c to f996361 Compare February 25, 2025 11:05
@codewithvk codewithvk marked this pull request as ready for review February 25, 2025 11:05
@codewithvk codewithvk requested a review from elzody as a code owner February 25, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elzody elzody Awaiting requested review from elzody elzody is a code owner

@juliusknorr juliusknorr Awaiting requested review from juliusknorr juliusknorr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codewithvk @juliusknorr