fix(dav): Use IUser::getDisplayName directly

No need to send this from the client. Signed-off-by: Christoph Wurst <[email protected]> Signed-off-by: nextcloud-command <[email protected]> [skip ci]
nextcloud · Mar 5, 2025 · ce264e9 · ce264e9
1 parent 60821a7
commit ce264e9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/apps/dav/lib/Controller/OutOfOfficeController.php b/apps/dav/lib/Controller/OutOfOfficeController.php
@@ -129,6 +129,7 @@ public function setOutOfOffice(
 			return new DataResponse(null, Http::STATUS_UNAUTHORIZED);
 		}
 
+		$replacementUser = null;
 		if ($replacementUserId !== null) {
 			$replacementUser = $this->userManager->get($replacementUserId);
 			if ($replacementUser === null) {
@@ -149,7 +150,7 @@ public function setOutOfOffice(
 			$status,
 			$message,
 			$replacementUserId,
-			$replacementUserDisplayName
+			$replacementUser?->getDisplayName()
 		);
 		$this->coordinator->clearCache($user->getUID());
 

diff --git a/apps/dav/openapi.json b/apps/dav/openapi.json
@@ -730,11 +730,6 @@
                                         "type": "string",
                                         "nullable": true,
                                         "description": "User id of the replacement user"
-                                    },
-                                    "replacementUserDisplayName": {
-                                        "type": "string",
-                                        "nullable": true,
-                                        "description": "Display name of the replacement user"
                                     }
                                 }
                             }

diff --git a/apps/dav/src/components/AbsenceForm.vue b/apps/dav/src/components/AbsenceForm.vue
@@ -219,8 +219,7 @@ export default {
 					lastDay: formatDateAsYMD(this.lastDay),
 					status: this.status,
 					message: this.message,
-					replacementUserId: this.replacementUser?.user ?? null,
-					replacementUserDisplayName: this.replacementUser?.displayName ?? null,
+					replacementUserId: this.replacementUser?.user ?? null
 				})
 				showSuccess(this.$t('dav', 'Absence saved'))
 			} catch (error) {