Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3): Trim the bucket name to make it DNS compatible #51192

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Draft

fix(s3): Trim the bucket name to make it DNS compatible #51192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/private/Files/ObjectStore/S3ConnectionTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ protected function parseParams($params) {
$this->id = 'amazon::' . $params['bucket'];

$this->test = isset($params['test']);
$this->bucket = $params['bucket'];
$this->bucket = trim($params['bucket']);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably already should be trimmed in the controller where the setting is saved - otherwise the invalid name will be in the config.

// Default to 5 like the S3 SDK does
$this->concurrency = $params['concurrency'] ?? 5;
$this->proxy = $params['proxy'] ?? false;
Expand Down
Loading