Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update appinfo for webhook_listeners app #51214

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions apps/webhook_listeners/appinfo/info.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,16 @@
<info xmlns:xsi= "http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="https://apps.nextcloud.com/schema/apps/info.xsd">
<id>webhook_listeners</id>
<name>Nextcloud webhook support</name>
<summary>Nextcloud webhook support</summary>
<description>Nextcloud webhook support</description>
<name>Nextcloud Webhook Support</name>
<summary>Listen for internal Nextcloud events and call external webhooks</summary>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weirdly technical. But this app kind of is, so I’m unsure.

<description># Description\nThis is an official Nextcloud app, which enables your Nextcloud to call webhooks, when certain Nextcloud events happen. This app does not have any (visible) user interface or settings. To configure your webhooks, you must use the [Rest API](https://docs.nextcloud.com/server/latest/developer_manual/_static/openapi.html#/operations/webhook_listeners-webhooks-create).</description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<description># Description\nThis is an official Nextcloud app, which enables your Nextcloud to call webhooks, when certain Nextcloud events happen. This app does not have any (visible) user interface or settings. To configure your webhooks, you must use the [Rest API](https://docs.nextcloud.com/server/latest/developer_manual/_static/openapi.html#/operations/webhook_listeners-webhooks-create).</description>
<description>This app enables your Nextcloud to call webhooks, when certain events happen. This app does not have any (visible) user interface or settings. To configure your webhooks, you must use the [Rest API](https://docs.nextcloud.com/server/latest/developer_manual/_static/openapi.html#/operations/webhook_listeners-webhooks-create).</description>

No need for a "description" header in the description.
Regarding "This is an official Nextcloud app", if I remember correctly we do not have such a notion. Some apps are maitaineds by us, some are not, but I do not think we want to put such a strong statement in a description. @jancborchardt might now?

<version>1.3.0</version>
<licence>agpl</licence>
<author>Côme Chilliet</author>
<namespace>WebhookListeners</namespace>
<documentation>
<admin>https://docs.nextcloud.com/server/latest/admin_manual/webhook_listeners/index.html</admin>
</documentation>

<types>
<filesystem/>
Expand Down