-
Notifications
You must be signed in to change notification settings - Fork 684
Fix issues with lint
console output
#6064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: Phil Ewels <[email protected]>
e4365f5
to
8d59b4f
Compare
Signed-off-by: Ben Sherman <[email protected]>
lint
console output
@@ -90,7 +90,7 @@ class StandardErrorListener implements ErrorListener { | |||
|
|||
@Override | |||
void onError(SyntaxException error, String filename, SourceUnit source) { | |||
term.bold().a(filename).reset() | |||
term.bold().a("error: ").a(filename).reset() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you like how this looks and I'll merge. I wonder if it would be better to put the error/warning label after the location
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't checked, but yeah I was thinking after the file name - like a prefix to the error message:
Error: Something bad happened.
Maybe with some colour too? Need to look at it for that though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Let me know how it looks
I think that it'd be improved with:
I've pushed updates to that effect - I've somewhat controversially gone for a background colour which really makes it stand out: In concise mode: Is that too much? I can revert it to the same text but just regular Red / Yellow font colour instead of background colour if you prefer. |
Signed-off-by: Phil Ewels <[email protected]>
c4cafe7
to
bd22701
Compare
would be nicer to keep it align (also using abbreviation e.g. |
Signed-off-by: Phil Ewels <[email protected]>
Cool, tempted to make .2 to show this :D |
Wondering if we should have a hanging block-colour to connect this to the context below 🤔 2 secs - will see if I can whip it up and send a screenshot |
Noticed that
nextflow lint
is a little too aggressive and can start eating back on the terminal from before its own launch command.. 😬Before this PR:
After this PR: