fix(use-aria-link): onclick deprecation warning for Button as Link

nextui-org · Jan 5, 2025 · a80d563 · a80d563
1 parent a43b156
commit a80d563
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.changeset/sixty-fireants-build.md b/.changeset/sixty-fireants-build.md
@@ -0,0 +1,5 @@
+---
+"@nextui-org/use-aria-link": patch
+---
+
+fix onclick deprecation warning for Button as Link (#4493)
diff --git a/packages/hooks/use-aria-link/src/index.ts b/packages/hooks/use-aria-link/src/index.ts
@@ -19,6 +19,8 @@ export interface AriaLinkOptions extends AriaLinkProps {
   "aria-current"?: DOMAttributes["aria-current"];
   /** Whether the link is disabled. */
   isDisabled?: boolean;
+  /** The role of the element */
+  role?: string;
   /**
    * The HTML element used to render the link, e.g. 'a', or 'span'.
    * @default 'a'
@@ -46,6 +48,7 @@ export function useAriaLink(props: AriaLinkOptions, ref: RefObject<FocusableElem
     onPressEnd,
     // @ts-ignore
     onClick: deprecatedOnClick,
+    role,
     isDisabled,
     ...otherProps
   } = props;
@@ -61,7 +64,7 @@ export function useAriaLink(props: AriaLinkOptions, ref: RefObject<FocusableElem
 
   let isMobile = isIOS() || isAndroid();
 
-  if (deprecatedOnClick && typeof deprecatedOnClick === "function") {
+  if (deprecatedOnClick && typeof deprecatedOnClick === "function" && role !== "button") {
     warn(
       "onClick is deprecated, please use onPress instead. See: https://github.com/nextui-org/nextui/issues/4292",
       "useLink",