-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(input): update type prop to include "file" #4444
docs(input): update type prop to include "file" #4444
Conversation
|
@not-a-ethan is attempting to deploy a commit to the NextUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe pull request modifies the documentation for the Changes
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/docs/content/docs/components/input.mdx (1)
334-334
: Consider enhancing the documentation with file input examples.While the type prop update is correct, the documentation would benefit from additional content:
- Add a "File Input" example section similar to the "Password Input" section
- Include information about file-specific features (accepted file types, size limits)
- Document file input validation considerations
Would you like me to help draft these additional documentation sections?
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/docs/content/docs/components/input.mdx
(1 hunks)
🔇 Additional comments (1)
apps/docs/content/docs/components/input.mdx (1)
334-334
: LGTM! Type prop updated correctly.
The addition of 'file' to the list of accepted values for the type prop is accurate and aligns with the PR objective.
Closes # N/A
📝 Description
Updated docs for Input component as it supports
type='file'
per #3268⛳️ Current behavior (updates)
Does not show that
file
is a valid option fortype
🚀 New behavior
Does display that it is a valid option
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
No
Summary by CodeRabbit
New Features
Input
component to support file uploads by adding"file"
as an accepted value for thetype
attribute.Documentation
Input
component to reflect the new accepted values for thetype
attribute.