fix: inert value in next15 #4491
Conversation
🦋 Changeset detectedLatest commit: 7b779e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 58 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis pull request addresses compatibility issues with the Changes
Sequence DiagramsequenceDiagram
participant App as Application
participant NextUtils as Shared Utils
participant NextJS as Next.js
App->>NextUtils: Call getInertValue()
NextUtils->>NextJS: Check Next.js version
NextJS-->>NextUtils: Return version
NextUtils->>NextUtils: Determine inert attribute
NextUtils-->>App: Return inert value
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
packages/utilities/shared-utils/src/functions.ts (2)
404-413: Consider using semver for robust version checks.
Dynamically importingnext/package.jsonmight introduce overhead and partial reliability issues if the version format changes. Relying onstartsWith("15")in other parts of the code is also somewhat fragile. Using a semver library would provide a more resilient approach.
415-419: Handle minor & patch releases when identifying Next.js 15.
Usingversion.startsWith("15")might work for now, but it may fail to capture or properly handle any future minor/patch releases (e.g., 15.10.x). A semantic version check would be more maintainable long-term..changeset/smart-eagles-hope.md (1)
1-5: Enhance the patch description for clarity.
Consider adding more details about this fix, including how it impacts Tabs or addresses the Next.js 15 error, to help future maintainers and users understand the scope of the patch more readily.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.changeset/smart-eagles-hope.md(1 hunks)packages/components/tabs/src/tab-panel.tsx(0 hunks)packages/utilities/shared-utils/src/functions.ts(2 hunks)
💤 Files with no reviewable changes (1)
- packages/components/tabs/src/tab-panel.tsx
winchesHe
force-pushed
the
fix/eng-1718-inert-value
branch
from
e5415f0 to
7b779e4
Compare
Closes #
📝 Description
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit
Bug Fixes
Tabscomponent in Next.js 15 environmentNew Features
getInertValuefunction with asynchronous version detectionChores
@nextui-org/shared-utilspackage with compatibility patch