Fairmat 2024: proposal on photoemission spectroscopy (MPES) #1424
Conversation
…ses by definitions in appdefs
…NXms with NXmicrostructure to avoid confusing the symbol convention with mass spectrometry as the abbreviation NXms may suggest
…con and eventually make this NXmicrostructure
Co-authored-by: Florian Dobener <[email protected]>
Fix docs CI to only keep orphan branch
…ate_system_set because that is what these conventions only talk about
Small modifications to clarify NXmpes
black formatting isort dev_tools
remove classes from contributed that have been moved to base_classes
lukaspie
force-pushed
the
fairmat-2024-mpes
branch
from
cf802ef
to
01bd128
Compare
|
This PR wants to create more than a dozen new base classes, along with major changes to several more, and yet there is minimal description of why they are needed and the links to other issues or other PRs provide little additional information. IMHO, it is impossible for the NIAC to assess such a huge PR as a single entity. I would suggest that there needs to be a separate PR for each base class, new or modified, containing a detailed explanation of why the PR is needed. This will slow the process down considerably, so at the next Telco I would suggest we discuss how to handle such a backlog, e.g., by assigning a couple of members to review each one and report back with comments so that we can have an expedited discussion and vote. However, I would recommend withdrawing this PR until we have decided how to proceed. |
This brings in the application definition
NXmpestogether with its specializationNXmpes_arpesandNXxpsand related new base classes.