Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate compare_genome_stats to nextflow_modules #7956

Open
3 of 4 tasks
Dishalodha opened this issue Mar 24, 2025 · 7 comments
Open
3 of 4 tasks

Migrate compare_genome_stats to nextflow_modules #7956

Dishalodha opened this issue Mar 24, 2025 · 7 comments
Assignees
Labels
new module Adding a new module

Comments

@Dishalodha
Copy link

Is there an existing module for this?

  • I have searched for the existing module

Is there an open PR for this?

  • I have searched for existing PRs

Is there an open issue for this?

  • I have searched for existing issues

Further Information

No response

Are you going to work on this?

  • If I'm planning to work on this module, I added myself to the Assignees to facilitate tracking who is working on the module
@Dishalodha
Copy link
Author

This module should be migrated to nextflow_modules following the guidelines in read me.
Please create a suitable nf-test accordingly.

@lgrochowalski
Copy link
Contributor

Do you have test data, I could test this module with?

@lgrochowalski lgrochowalski self-assigned this Mar 24, 2025
@Dishalodha
Copy link
Author

Dishalodha commented Mar 24, 2025

yes, this module uses 2 files core_stats and ncbi_stats and compares them. You can use them from this repo ensembl-genomio. Please download this repo and install the requirements. You can also test the python module genome_stats_compare to check the output.

core_stats
ncbi_stats

db is in this format:
[production_name:"test_db", server:[host:"test_host", port:"1111", user:"ensro"], species:"test_species"]

@lgrochowalski
Copy link
Contributor

In original module there is a value "stats" in the output channel. Should I have it in the new module or drop it? If I should keep it, then how should I describe it in the meta.yml?

@Dishalodha
Copy link
Author

we would still want to keep the value "stats". I will check for an example of output tuple

@Dishalodha Dishalodha moved this from To do to In progress in Hackathon March 2025 Mar 26, 2025
@lgrochowalski
Copy link
Contributor

lgrochowalski commented Mar 26, 2025

I think, I'm ready to create PR. How can I push changes to your repo?

@Dishalodha
Copy link
Author

Dishalodha commented Mar 27, 2025

Hi @lgrochowalski, could you fork the repo and create a pull request from the forked repo into nextflow_modules for us to review?

@Dishalodha Dishalodha moved this from In progress to Ready for review in Hackathon March 2025 Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new module Adding a new module
Projects
Status: Ready for review
Development

No branches or pull requests

2 participants