Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OAuth flow for ArcGIS Plugin #225

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Update OAuth flow for ArcGIS Plugin #225

merged 4 commits into from
Nov 1, 2024

Conversation

ryanslatten
Copy link
Contributor

This ticket fixes an issue where the OAuth window could close unexpectedly when there are other message events and also updates the authToken when the refreshToken is used for OAuth

Copy link
Member

@newmanw newmanw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor refactor to move sanitization outside the observation processor.

plugins/arcgis/service/src/ObservationProcessor.ts Outdated Show resolved Hide resolved
plugins/arcgis/service/src/ObservationProcessor.ts Outdated Show resolved Hide resolved
@newmanw newmanw merged commit af4a7c9 into develop Nov 1, 2024
2 of 5 checks passed
@ryanslatten ryanslatten deleted the oauth-updates branch November 1, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants