Explicit forward proxy support for HTTP with Basic Auth #1201
+733
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
dhurley
reviewed
Aug 8, 2025
aphralG
reviewed
Aug 11, 2025
craigell
reviewed
Aug 15, 2025
craigell
approved these changes
Aug 19, 2025
dhurley
reviewed
Aug 20, 2025
dhurley
reviewed
Aug 22, 2025
aphralG
reviewed
Aug 22, 2025
aphralG
reviewed
Aug 25, 2025
|
|
||
| // Test missing username/password | ||
| proxyMissing := &config.Proxy{URL: "http://localhost:8080"} | ||
| setProxyWithBasicAuth(ctx, proxyMissing, u) // Should not panic |
There was a problem hiding this comment.
Could a check be added to this test to check that we get the log output we expect if its not set ?
Suggested change
| setProxyWithBasicAuth(ctx, proxyMissing, u) // Should not panic | |
| logBuf := &bytes.Buffer{} | |
| stub.StubLoggerWith(logBuf) | |
| // Test missing username/password | |
| proxyMissing := &config.Proxy{URL: "http://localhost:8080"} | |
| setProxyWithBasicAuth(ctx, proxyMissing, u) | |
| helpers.ValidateLog(t, "Unable to configure OTLP exporter proxy, "+ | |
| "username or password missing for basic auth", logBuf) |
| return tlsConf, nil | ||
| } | ||
|
|
||
| //nolint:lll //This needs to be in a single line. |
There was a problem hiding this comment.
Could you add more detail to the comment about why it needs to be a single line
There was a problem hiding this comment.
If I break this line into 2 either I am getting gofumpt error or compiler error.
| } | ||
| ctx, cancel := context.WithTimeout(context.Background(), 2*time.Second) | ||
| defer cancel() | ||
| _, _ = DialViaHTTPProxy(ctx, proxyConf, "example.com:443") |
There was a problem hiding this comment.
Should the error returned here be checked ?
| return false | ||
| } | ||
|
|
||
| func TestDialViaHTTPProxy_InvalidCAPath(t *testing.T) { |
There was a problem hiding this comment.
Could TestDialViaHTTPProxy_InvalidCAPath TestDialViaHTTPProxy_MissingCertKey & TestDialViaHTTPProxy_InvalidProxyURL be one test with different test parameters in a struct ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)