Push v3 results to QE grafana dashboard #1216
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NutsaB
changed the title
craigell
reviewed
Aug 22, 2025
craigell
approved these changes
Aug 25, 2025
aphralG
reviewed
Aug 25, 2025
| @@ -32,19 +33,22 @@ func (s *AuxiliaryTestSuite) SetupSuite() { | |||
| t := s.T() | |||
| // Expect errors in logs should be false for recconnection tests | |||
| // For now for these test we will skip checking the logs for errors | |||
| slog.Info("starting auxiliary command server tests") | |||
There was a problem hiding this comment.
would t.Log() work instead of using slog for these or does the dashbaord need them to be slog ?
There was a problem hiding this comment.
Or is there a way to have the test Suite handle the the log message in the setup so its not needed for every test ?
john-david3
reviewed
Aug 26, 2025
| set -euo pipefail | ||
|
|
||
| # Check if required arguments are provided | ||
| if [ $# -lt 3 ]; then |
There was a problem hiding this comment.
Suggested change
| if [ $# -lt 3 ]; then | |
| if [ "$#" -ne 3 ]; then |
|
|
||
| # Validate input file exists | ||
| if [ ! -f "$INPUT_FILE" ]; then | ||
| echo "Error: Input file $INPUT_FILE does not exist." |
There was a problem hiding this comment.
Suggested change
| echo "Error: Input file $INPUT_FILE does not exist." | |
| echo "Error: Input file not found: $INPUT_FILE" |
| fi | ||
|
|
||
| format_log() { | ||
| local line="$1" |
There was a problem hiding this comment.
Does this need to be local?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)