Skip to content

Fix syslog server being removed after config apply #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix syslog server being removed after config apply #1225

wants to merge 1 commit into from

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented Aug 22, 2025

Proposed changes

The previousNAPSysLogServer variable wasn't being updated in the collector plugin.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@dhurley dhurley self-assigned this Aug 22, 2025
@dhurley dhurley added the v3.x Issues and Pull Requests related to the major version v3 label Aug 22, 2025
@dhurley dhurley requested a review from a team as a code owner August 22, 2025 14:25
@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks labels Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean-breen sean-breen sean-breen approved these changes

@aphralG aphralG aphralG approved these changes

Assignees

@dhurley dhurley

Labels
bug Something isn't working chore Pull requests for routine tasks v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhurley @sean-breen @aphralG