Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for secrets for backendtlspolicy #2976

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

porthorian
Copy link

@porthorian porthorian commented Jan 6, 2025

WIP

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Give a brief overview of the problem or feature being addressed.

Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

relates to #2629

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


Copy link
Contributor

github-actions bot commented Jan 6, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@porthorian
Copy link
Author

I have hereby read the F5 CLA and agree to its terms

@sindhushiv sindhushiv added the tracking To track external issues or changes that will affect NKG label Jan 7, 2025
@kate-osborn
Copy link
Contributor

Hi @porthorian thanks for taking this work on!

Are you looking for a review, or would you prefer me to wait until you mark this PR as ready?

@mpstefan mpstefan removed the tracking To track external issues or changes that will affect NKG label Jan 7, 2025
@porthorian
Copy link
Author

@kate-osborn I'll mark ready when I feel it's good for a review.
Not very functional yet and haven't written tests or tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

4 participants