CR 839, Build Ubuntu images #840
Conversation
|
My testing is limited, I don't have the awsecr and stacklibrary credentials to test everything, but the new Ubuntu dockerfile seems to work well in my modest test deployment. |
|
Thanks for the contribution @nkadel! It's still not clear if we want to have it included (and my feeling is still we don't). It looks like this PR has unrelated changes (e.g. a bump to 1.25.2), can you fix that for an easier review? Additionally, I don't think it makes sense to base images off non-LTS version of Ubuntu. |
|
I set the Ubuntu consistently to "jammy" for now, which is the current 22.04LTS version, with a comment to mention that. I admit that the name based rather than number based releases are a consistent confusion for Ubuntu, and are a Debian practice I wish they'd not preserved. |
|
Closing for the reasons outlined in #839 |
| done | ||
|
|
||
| for variant in debian-perl; do | ||
| variantAliases=( "${versionAliases[@]/%/-perl}" ) | ||
| variantAliases=( "${variantAliases[@]//latest-/}" ) | ||
|
|
||
| for tag in ${variantAliases[@]}; do |
There was a problem hiding this comment.
This is whitespace consistency change, including the "tag" logic within rather than out of line with the variant logic that includes it.
Proposed changes
Provide Ubuntu images, based on existing Debian images, to provide Ubuntu images with contemporary nginx and similar optimizations.
Checklist
Before creating a PR, run through this checklist and mark each as complete:
CONTRIBUTINGdocument./update.shand ensured all entrypoint/Dockerfile template changes have been applied to the relevant image entrypoint scripts & Dockerfiles