Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Alpine 3.19 #851

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

jnoordsij
Copy link
Contributor

Proposed changes

Updates the images to use Alpine 3.19 as default version. See also https://alpinelinux.org/posts/Alpine-3.19.0-released.html.

Note: given that this requires built binaries for the new Alpine version and won't take any effect until an actual new release of nginx itself, this PR is intentionally marked as draft, so it can function both as a heads-up about the new release and a place that allows for subscription to any potential updates. It can then be merged later at any convenient time when everythins is ready. However, if it is still preferable to close this in the meantime, feel free to do so.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the CONTRIBUTING document
  • I have run ./update.sh and ensured all entrypoint/Dockerfile template changes have been applied to the relevant image entrypoint scripts & Dockerfiles
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation

@harryzcy
Copy link

@jnoordsij Is there any updates to this? I think triggering the workflows again will make CI to pass.

@thresheek
Copy link
Collaborator

Hey @harryzcy @jnoordsij

Thanks for checking in. I'm not sure moving stable to alpine 3.19 makes sense since there is no new stable nginx release since then.

As for mainline, we're likely to have a release next week, and I think it'll be fine merging it then and moving a new mainline release to 3.19.

@eromano
Copy link

eromano commented Feb 6, 2024

@thresheek is there any update on this? Consume the new alpine will allow to fix some security issues

@thresheek
Copy link
Collaborator

JFYI, I've decided to postpone the move to 3.19 for mainline since the newly released version contains security fixes. It would have been a bit of a change for those willing to update to also change the underlying OS. Hope it's ok.

@rfilgas
Copy link

rfilgas commented Feb 28, 2024

Are these security issues on the roadmap to resolve for mainline?
CVE-2023-47038
CVE-2024-25062

@jnoordsij
Copy link
Contributor Author

Are these security issues on the roadmap to resolve for mainline? CVE-2023-47038 CVE-2024-25062

I'm not sure how these are in any way related to this MR; but I will gladly point you to https://github.com/docker-library/faq?tab=readme-ov-file#why-does-my-security-scanner-show-that-an-image-has-cves for some additional details on how CVEs are handled in Docker Official Images.

@jnoordsij
Copy link
Contributor Author

For reference/those subscribed here: 29d5001 updates mainline (currently 1.25.x) to use Alpine 3.19; the new image should be available soon after docker-library/official-images#16614 is merged.

@oxpa
Copy link
Collaborator

oxpa commented Apr 17, 2024

Due to a couple of mistakes on my side the correct PR is docker-library/official-images#16622

@jnoordsij
Copy link
Contributor Author

With the (upcoming) release of 1.26.0, I think the stable image can now be updated as well. Feel free to merge this; otherwise I'll close once the 1.26.0 image with new Alpine is released.

@jnoordsij jnoordsij marked this pull request as ready for review April 23, 2024 15:08
@thresheek thresheek merged commit 308c492 into nginxinc:master Apr 23, 2024
8 of 9 checks passed
@thresheek
Copy link
Collaborator

Thanks @jnoordsij !

@jnoordsij jnoordsij deleted the update-alpine-3.19 branch April 23, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants