Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to generate and sync scripts #870

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Conversation

thresheek
Copy link
Collaborator

Proposed changes

As reported in #869, the bookworm tags did not propagate to the AWS mirror. This PR fixes that, and also other minor issues with the sync script such as specifying a proper architecture when pulling images since some docker runtimes can be picky about that.

Also, simplified a library generation script.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the CONTRIBUTING document
  • I have run ./update.sh and ensured all entrypoint/Dockerfile template changes have been applied to the relevant image entrypoint scripts & Dockerfiles
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation

This mostly synchronises it with generate-stackbrew-library.sh script.
alpine-slim is built on all architectures and is not different to other
alpine versions, so no reason to have a separate section for it anymore.
@thresheek thresheek merged commit 6f3d62b into nginxinc:master Mar 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant