Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add riscv64 support #898

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Add riscv64 support #898

merged 1 commit into from
Dec 3, 2024

Conversation

mengzhuo
Copy link
Contributor

@mengzhuo mengzhuo commented Jun 4, 2024

Proposed changes

Since riscv64 had be adopted in alpine 3.20 (stable, released in May 22), we can add riscv64 and update alpine.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the CONTRIBUTING document
  • I have run ./update.sh and ensured all entrypoint/Dockerfile template changes have been applied to the relevant image entrypoint scripts & Dockerfiles
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation

@mmoll
Copy link

mmoll commented Aug 15, 2024

@mengzhuo after the latest merges, only the riscv64 addition should remain after a rebase

@mengzhuo mengzhuo changed the title Add riscv64 support and update alpine to 3.20 Add riscv64 support Aug 15, 2024
@mengzhuo
Copy link
Contributor Author

@mmoll Thanks for your kind reminder, done.

@thresheek
Copy link
Collaborator

Thanks, I plan to add it soon. Can you confirm those dockerfiles compile fine on riscv64 hardware? I don't have access to it.

@mengzhuo
Copy link
Contributor Author

@thresheek Sure! Here is logs

root@visionfive2-2:~/docker-nginx/stable/alpine-slim# uname -a
Linux visionfive2-2 6.8.0-40-generic #40.1-Ubuntu SMP PREEMPT_DYNAMIC Wed Jul 31 06:23:15 UTC 2024 riscv64 riscv64 riscv64 GNU/Linux
root@visionfive2-2:~/docker-nginx/stable/alpine-slim# podman build -t nginx:alpine-slim .
...build log truncated...
root@visionfive2-2:~/docker-nginx/stable/alpine-slim# podman image inspect nginx:alpine-slim | grep Architecture
          "Architecture": "riscv64",
root@visionfive2-2:~/docker-nginx/stable/alpine-slim# podman run -d -p 80:80 --rm nginx:alpine-slim

curl localhost works fine.

@mmoll
Copy link

mmoll commented Nov 29, 2024

@thresheek Gentle nudge...

@thresheek thresheek merged commit 9bef259 into nginxinc:master Dec 3, 2024
@thresheek
Copy link
Collaborator

Thanks!

O-I library PR submitted as well: docker-library/official-images#18005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants