-
Notifications
You must be signed in to change notification settings - Fork 3
Killing Oldframe #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Killing Oldframe #276
Conversation
❌ Playwright visual snapshot differences were detected.View the Playwright report |
✅ Deploy Preview will be available once build job completes!
|
Tab groups not working as expected - taking a look. |
F5 Sites button not working as expected as well. Related to the tabs group. Edit: Resolved |
❌ One or more of the commit messages in this PR do not match the nginx-hugo-theme git guidelines, please check the CI job for more details on which commits were flagged and why.Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR. |
0f6ac99
to
6de8fe8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments around specifically tab group accessibility
* Qualtrics: Fixed survey going over sidebar * Qualtrics: Fixed responsiveness
* Card: Handle case of no inner for cards * Card: Updated test product landing page
* Redocly: Add support for content on redocly pages * Redocly: Fix redoc sidebar hiding under the header * Redocly: Fix mobile sidebar alignment --------- Co-authored-by: Lam Nguyen <[email protected]>
Fix usages of color-foreground. It's oklch based, but had usages directly on color without oklch wrapper. Widen sidebar to 24rem
* Cards: Removed card-layout shortcode + replaced showAsCards with new param name * Cards: Removed showAsSingleRow option
* Grid: Changed min width of parent grid to be smaller * Grid: Removed overflow on callouts + codeblocks + set min width to zero * Grid: Fixed sidebar width * Grid: Added breadcrumb line overflow fully
* Card: Add even spacing * Card: Add variable for spacing * Card: Added displacement to gap to accord for grip gap * Card: Add hover effect to all cards
* Card: Fix icon size + add alignment * Card: Fix issue with icon shrinking
* Coveo: Fix clipping on sidebar + touch up colors * Coveo: Refactor variables * Coveo: Added search on homepage + fixed mobile renderings * Coveo: Make font-size consistent on searchbar * Cards: Fixed styling on search
Proposed changes
Lots of removing
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentREADME.md
andCHANGELOG.md
)