Skip to content

Conversation

lamATnginx
Copy link
Collaborator

Proposed changes

Lots of removing

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx requested a review from a team as a code owner June 9, 2025 14:46
Copy link

github-actions bot commented Jun 9, 2025

Playwright visual snapshot differences were detected.

View the Playwright report
To approve the snapshot changes and update the snapshots, please comment: /approve-snapshots

Copy link

github-actions bot commented Jun 9, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/276/

@nginx-jack
Copy link
Collaborator

Tab groups not working as expected - taking a look.

@lamATnginx
Copy link
Collaborator Author

lamATnginx commented Jun 12, 2025

F5 Sites button not working as expected as well. Related to the tabs group.

Edit: Resolved

Copy link

❌ One or more of the commit messages in this PR do not match the nginx-hugo-theme git guidelines, please check the CI job for more details on which commits were flagged and why.

Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

@lamATnginx lamATnginx force-pushed the mainframe branch 3 times, most recently from 0f6ac99 to 6de8fe8 Compare June 12, 2025 14:14
Copy link
Member

@TasoOneAsia TasoOneAsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments around specifically tab group accessibility

lamATnginx and others added 30 commits July 25, 2025 09:20
* Qualtrics: Fixed survey going over sidebar

* Qualtrics: Fixed responsiveness
* Card: Handle case of no inner for cards

* Card: Updated test product landing page
* Redocly: Add support for content on redocly pages

* Redocly: Fix redoc sidebar hiding under the header

* Redocly: Fix mobile sidebar alignment

---------

Co-authored-by: Lam Nguyen <[email protected]>
Fix usages of color-foreground. It's oklch based,
but had usages directly on color without oklch
wrapper.

Widen sidebar to 24rem
* Cards: Removed card-layout shortcode + replaced showAsCards with new param name

* Cards: Removed showAsSingleRow option
* Grid: Changed min width of parent grid to be smaller

* Grid: Removed overflow on callouts + codeblocks + set min width to zero

* Grid: Fixed sidebar width

* Grid: Added breadcrumb line overflow fully
* Card: Add even spacing

* Card: Add variable for spacing

* Card: Added displacement to gap to accord for grip gap

* Card: Add hover effect to all cards
* Card: Fix icon size + add alignment

* Card: Fix issue with icon shrinking
* Coveo: Fix clipping on sidebar + touch up colors

* Coveo: Refactor variables

* Coveo: Added search on homepage + fixed mobile renderings

* Coveo: Make font-size consistent on searchbar

* Cards: Fixed styling on search
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants