Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add angular animations and dialog close transition #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add angular animations and dialog close transition #108

wants to merge 1 commit into from

Conversation

va-stefanek
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Issue Number: #40

@stackblitz
Copy link

stackblitz bot commented Jun 30, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@va-stefanek
Copy link
Author

@NetanelBasal I have added new animation and migrated the old one to use angular animations. Solutions is strongly inspired by angular/components dialog.

@va-stefanek
Copy link
Author

@NetanelBasal up

@NetanelBasal
Copy link
Member

Can you tell why do we need this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@va-stefanek @NetanelBasal