rework

.github/workflows/autobuild.yml

@@ -95,15 +95,15 @@ jobs:
            - config_name:           AndroidAPK (artifact+codeQL)
              target_os:             android
              building_on_os:        ubuntu-20.04
-             cmd1_prebuild:         "sh ./autobuild/android/autobuild_apk_1_prepare.sh "
-             cmd2_build:            "./autobuild/android/autobuild_apk_2_build.sh "
-             cmd3_postbuild:        "./autobuild/android/autobuild_apk_3_copy_files.sh "
+             cmd1_prebuild:         "sh ./autobuild/android/autobuild_apk_1_prepare.sh" # this step needs sh instead of bash for permissions
+             cmd2_build:            "./autobuild/android/autobuild_apk_2_build.sh"
+             cmd3_postbuild:        "./autobuild/android/autobuild_apk_3_copy_files.sh"
              uses_codeql:           true
 
            - config_name:           Linux (artifacts+codeQL)
              target_os:             linux
              building_on_os:        ubuntu-20.04
-             cmd1_prebuild:         "sh ./autobuild/linux/autobuild_deb_1_prepare.sh"
+             cmd1_prebuild:         "sh ./autobuild/linux/autobuild_deb_1_prepare.sh" # this step needs sh instead of bash for permissions
              cmd2_build:            "./autobuild/linux/autobuild_deb_2_build.sh"
              cmd3_postbuild:        "./autobuild/linux/autobuild_deb_3_copy_files.sh"
              uses_codeql:           true
@@ -113,7 +113,7 @@ jobs:
              building_on_os:        macos-10.15
              cmd1_prebuild:         "./autobuild/mac/codeQL/autobuild_mac_1_prepare.sh"
              cmd2_build:            "./autobuild/mac/codeQL/autobuild_mac_2_build.sh"
-             cmd3_postbuild:        "./autobuild/mac/codeQL/autobuild_mac_3_copy_files.sh"
+             cmd3_postbuild:        false
              uses_codeql:           true
 
            - config_name:           MacOS (artifacts)

autobuild/ensure_THIS_JAMULUS_PROJECT_PATH.sh

@@ -27,7 +27,7 @@ if [ -d "$THIS_JAMULUS_PROJECT_PATH" ]; then
   #python -c "import os; print(os.path.abspath(\"${THIS_JAMULUS_PROJECT_PATH}\"));"
   echo "THIS_JAMULUS_PROJECT_PATH exists (absolute): ${THIS_JAMULUS_PROJECT_PATH}"
 else
-    echo "ERROR: non-existing THIS_JAMULUS_PROJECT_PATH: ${THIS_JAMULUS_PROJECT_PATH}"
+    echo "ERROR: THIS_JAMULUS_PROJECT_PATH must reference an existing directory: \"${THIS_JAMULUS_PROJECT_PATH}\""
     exit 1
 fi
 

autobuild/linux/autobuild_deb_1_prepare.sh

@@ -11,7 +11,6 @@
 
 echo "Update system..."
 sudo apt-get -qq update
-# We don't upgrade the packages. If this is needed, just uncomment this line
-# sudo apt-get -qq -y upgrade
+
 echo "Install dependencies..."
 sudo apt-get -qq -y install devscripts build-essential debhelper libjack-jackd2-dev qtbase5-dev qttools5-dev-tools

autobuild/mac/artifacts/autobuild_mac_1_prepare.sh

@@ -7,13 +7,10 @@
 ###################
 
 echo "Install dependencies..."
-#brew install qt5
-#brew link qt5 --force
 python3 -m pip install aqtinstall
-
 python3 -m aqt install --outputdir /usr/local/opt/qt 5.9.9 mac desktop
-# add the qt binaries to the path
 
+# add the qt binaries to the path
 export -p PATH=/usr/local/opt/qt/5.9.9/clang_64/bin:"${PATH}"
 echo "::set-env name=PATH::${PATH}"
 echo "the path is ${PATH}"