update(doc): solution for Feature combineReducers and AOT #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdeschryver
requested changes
Jun 7, 2018
docs/store/api.md
Outdated
| configuration option to provide an array of meta-reducers that are composed from right to left. | ||
| @ngrx/store composes your map of reducers into a single reducer. | ||
|
|
||
| > Developers can think of metaReducers as hooks into the action->reducer pipeline. MetaReducers allow develoeprs to pre-process actions actions before *normal* reducers are invoked. |
There was a problem hiding this comment.
allow developers to pre-process actions actions before
docs/store/api.md
Outdated
| and then the following will work with AOT: | ||
|
|
||
| ```ts | ||
| import { reducerA } from './+state/a.reducer'; |
There was a problem hiding this comment.
import { reducerA } from './state/a.reducer';
(without the + sign)
|
@tdeschryver if you want to just make those couple of edits here we can land this. |
timdeschryver
approved these changes
Jun 13, 2018
|
@brandonroberts Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The angular compiler needs statically analyzes code during AOT. As such you can’t call functions like
combineReducers()when defining metadata in the NgModule.Refs #306