Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: set explicit packageGroupName's #4687

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #4682

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

According to the docs this should fix it, https://github.com/angular/angular-cli/blob/main/docs/specifications/update.md#migration . I don't know a way to test this though without releasing a new version.

Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit a99a07f
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/67973d9d103cde0008a81156

@markostanimirovic markostanimirovic merged commit 44cb328 into main Jan 27, 2025
10 checks passed
@markostanimirovic markostanimirovic deleted the packageGroupName branch January 27, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: update v19 migration guide to contain instruction about upgrading @ngrx/signals
3 participants