Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add protocol (e.g. http or https) to ServerConfiguration #66

Merged
merged 15 commits into from
Nov 19, 2024
Merged

Add protocol (e.g. http or https) to ServerConfiguration #66

merged 15 commits into from
Nov 19, 2024

Conversation

kristofhennebel
Copy link
Contributor

Add protocol (e.g. http or https) to ServerConfiguration

@nhenneaux
Copy link
Owner

https://nicolas.henneaux.io is unreachable for now (I have some issue with OCA that deleted my setup), could you remove the endpoint from the list of endpoints?

@nhenneaux
Copy link
Owner

https://nicolas.henneaux.io is unreachable for now (I have some issue with OCA that deleted my setup), could you remove the endpoint from the list of endpoints?

I finally got it fixed using Cloudflare, could you re-active it. Very sorry for changing again :(

@nhenneaux
Copy link
Owner

I fixed nicolas.henneaux.io tests failing and java23 issue in #67, can you rebase on master?

@kristofhennebel
Merge remote-tracking branch 'upstream/master'
bbdd1a9 
# Conflicts:
#	monitored-httpclient/src/test/java/com/github/nhenneaux/resilienthttpclient/monitoredclientpool/HttpClientPoolTest.java
@kristofhennebel
fix tests
edf0ab3
@kristofhennebel
extra test
d1ccb7a
@nhenneaux
Copy link
Owner

two tests are failing

Error:    ResilientClientTest.throwForInvalidUrl:125 Unexpected exception type thrown, expected: <java.lang.IllegalArgumentException> but was: <java.lang.NullPointerException>
Error:    SingleIpHttpClientTest.shouldFailOnMalformedUrl:150 expected: <Cannot build health URI from ServerConfiguration{hostname='com.github.nhenneaux.resilienthttpclient.monitoredclientpool.SingleIpHttpClientTest.shouldCreateClientWithoutRefresh', port=-234, healthPath='&dfsfsd', connectionHealthCheckPeriodInSeconds=1, dnsLookupRefreshPeriodInSeconds=1, healthReadTimeoutInMilliseconds=-1, failureResponseCountThreshold= 0}> but was: <Cannot build health URI from ServerConfiguration{hostname='com.github.nhenneaux.resilienthttpclient.monitoredclientpool.SingleIpHttpClientTest.shouldCreateClientWithoutRefresh', port=-234, healthPath='&dfsfsd', connectionHealthCheckPeriodInSeconds=1, dnsLookupRefreshPeriodInSeconds=1, healthReadTimeoutInMilliseconds=-1, failureResponseCountThreshold= 0, protocol= https}>

@nhenneaux
Copy link
Owner

Another test failing with Set instead of list

Supported protocols are [http, https], but was: abc> but was: <Supported protocols are [https, http], but was: abc>

@nhenneaux nhenneaux merged commit 5b6b2e7 into nhenneaux:master Nov 19, 2024
13 of 17 checks passed
@nhenneaux
Copy link
Owner

I have just deployed v1.0.4, it will be very soon available in maven central https://repo1.maven.org/maven2/com/github/nhenneaux/resilienthttpclient/resilient-httpclient/1.0.4/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhenneaux nhenneaux nhenneaux left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristofhennebel @nhenneaux