Skip to content

fix virtual channel name logic with library interpreter and DAQmx 24.5+ #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 22, 2025

Conversation

zhindes
Copy link
Collaborator

@zhindes zhindes commented May 21, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

Why should this Pull Request be merged?

Improves API consistency across ADEs

What testing has been done?

New unit tests:

  • Some disabled on gRPC since our fix isn't portable
  • Some xfail if executing in a version of DAQmx older than 24.5
  • Validated that everything is as expected on 24.3 (old) and 24.5 (new)

@zhindes zhindes changed the title Users/zhindes/virtchan fix virtual channel name logic with library interpreter and DAQmx 24.5+ May 21, 2025
Copy link

github-actions bot commented May 21, 2025

Test Results

    34 files  ±  0      34 suites  ±0   57m 50s ⏱️ -49s
 2 431 tests + 35   2 077 ✅ + 35    354 💤 ±0  0 ❌ ±0 
43 914 runs  +812  37 662 ✅ +812  6 252 💤 ±0  0 ❌ ±0 

Results for commit a245ec8. ± Comparison against base commit 3b70f51.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

@zhindes zhindes requested a review from bkeryan May 22, 2025 15:27
@zhindes zhindes enabled auto-merge (squash) May 22, 2025 15:28
@zhindes zhindes merged commit 1b59ca3 into master May 22, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nidaqmx does not generate numbered virtual channel names correctly
2 participants