-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve strings for tizen plugin #3696
base: dev
Are you sure you want to change the base?
Conversation
Hum, Now that the same plugin is more generic and provide information for several external consumer apps, the generic name is fine, but I think we should also propose a generic description and don't try to be exhaustive in the external apps that can use it (to simplify maintainability of this description later...) It's more within aaps doc (if we want to provide an exhaustive list in one place), or within external app doc like G-Watch documentation, ...), to provide this kind of information 🤔. |
So suggested name of plugin is fine. Description could be changed to something like: Enables data broadcasting to various companion apps on Samsung Tizen OS, Wear OS, and Android Auto devices. |
I think no "and" at the end of the description which suggest the list is finished and exhaustive 🧐. Or (if we think it's better to provide exemples to be a bit more precise), something like: The idea is if any additional new external apps include this broadcasting management, then the plugin description remains true and don't need to be updated... |
I agree that it's smart to avoid putting an description that adds for the need to update string all the time. Something like this could work: I can update wiki for this plugin to reflect what's actually supported at this moment. Known apps:
@MilosKozak What you think about the above? |
Quality Gate passedIssues Measures |
For #3692
New Plugin name:
Companion App Broadcast
New Plugin description:
Enables data broadcasting to various external companion apps
Current string
| ![image]