Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve strings for tizen plugin #3696

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

olorinmaia
Copy link
Contributor

@olorinmaia olorinmaia commented Jan 4, 2025

For #3692

New Plugin name:
Companion App Broadcast
New Plugin description:
Enables data broadcasting to various external companion apps

Current string
image | ![image]

@Philoul
Copy link
Contributor

Philoul commented Jan 11, 2025

Hum,
If plugin is dedicated to synchronize data with only one single external app, we can use an explicit name and explicit description.

Now that the same plugin is more generic and provide information for several external consumer apps, the generic name is fine, but I think we should also propose a generic description and don't try to be exhaustive in the external apps that can use it (to simplify maintainability of this description later...)

It's more within aaps doc (if we want to provide an exhaustive list in one place), or within external app doc like G-Watch documentation, ...), to provide this kind of information 🤔.

@olorinmaia
Copy link
Contributor Author

olorinmaia commented Jan 11, 2025

So suggested name of plugin is fine.

Description could be changed to something like:

Enables data broadcasting to various companion apps on Samsung Tizen OS, Wear OS, and Android Auto devices.

@Philoul
Copy link
Contributor

Philoul commented Jan 11, 2025

I think no "and" at the end of the description which suggest the list is finished and exhaustive 🧐.
So either (without any name)
"Enables data broadcasting to various external companion apps"

Or (if we think it's better to provide exemples to be a bit more precise), something like:
"Enables data broadcasting to various companion apps like G-Watch for Tizen or Wear OS, several Android Auto devices..."

The idea is if any additional new external apps include this broadcasting management, then the plugin description remains true and don't need to be updated...

@olorinmaia
Copy link
Contributor Author

olorinmaia commented Jan 11, 2025

I agree that it's smart to avoid putting an description that adds for the need to update string all the time.

Something like this could work:
Enables data broadcasting to various external companion apps

I can update wiki for this plugin to reflect what's actually supported at this moment.
https://androidaps.readthedocs.io/en/latest/Getting-Started/Watches.html#samsung-tizen

Known apps:

  • G-Watch App (Samsung Tizen watches)
  • G-Watch Wear App (all Wear OS 3 and 4 watches, not only Samsung Wear OS)
  • GlucoDataHandler app (all Wear OS 3, 4 and 5 watches)
  • GlucoDataAuto (AndroidAuto companion app)

@MilosKozak What you think about the above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants