Always calculate TDD

[simonp22]

This PR is in response to nightscout/Trio#393.

At the moment just a proposed solution up for discussion in nightscout/Trio#393

[mountrcg]

this is fine and tested

[mountrcg]

hold that thought for a moment

@simonp22 could you close this and reopen with target branch being tcd please? Please also adjust line

trio-oref/lib/determine-basal/determine-basal.js

Line 644 in 06ca64b

if (weightPercentage < 1 && weightedAverage > 0) {

to weightedAverage > 1

[bjornoleh]

I changed the base branch to tcd. Please check if this looks good. @mountrcg

[simonp22]

hold that thought for a moment

@simonp22 could you close this and reopen with target branch being tcd please? Please also adjust line

trio-oref/lib/determine-basal/determine-basal.js

Line 644 in 06ca64b

if (weightPercentage < 1 && weightedAverage > 0) {

to weightedAverage > 1

Could there not be scenarios where weightedAverage < 1 here? Is it safe to ignore those?

[mountrcg]

@simonp22 weightedAverage is a TDD value and one of the fault catches in dynISF sets that value to 1. I do not think anyone will ever have a TDD of 1 or smaller. So in order not to have that fault catch populate a TDD = 1, I suggest the quickfix to make it >1

[mountrcg]

unfortunatly the crew voted to not release this for Trio 0.2.x or whatnot, so it will come with 1.0

[simonp22]

Changes now made