Skip to content

fixes broken discriminators of float types by disabling it #24938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented May 6, 2025

type
  Case = object
    case x: float
    of 1.0:
      id: int
    else:
      ta: float

It segfaults with fatal error: invalid kind for firstOrd(tyFloat)

It was caused by #12591 and has affected discriminators of float types since 1.2.x

I think no one is using discriminators of float types anyway so I simply disable it like what was done to discriminators of string types (ref #15080)

ref nim-lang/nimony#1069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant