Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove 'elk' mentions from config files #12

Merged

Conversation

IonianPlayboy
Copy link
Collaborator

I have tried to limit the scope of the changes as much as possible to the items described in #6 , on the Elk references > Config files list.

  • The Docker image and service are now named nimbus
  • All the links in config files have been updated to the new domain nimbus.town
  • The translation status is now written in nimbus-translation-status.jsonand is typed as NimbusTranslationStatus

I'm pretty confident theses changes should not break anything, except the Docker-related ones. To my knowledge, only updating names should not have any impact on how it runs, but I was not able to test it to confirm my intuition.

@userquin
Copy link
Contributor

You also need to replace the name in the docs folder:

  • docs/.gitignore
  • docs/components/global/TranslationState.vue
  • docs/eslint.config.js

@IonianPlayboy
Copy link
Collaborator Author

IonianPlayboy commented Nov 23, 2024

You also need to replace the name in the docs folder:

* `docs/.gitignore`

* `docs/components/global/TranslationState.vue`

* `docs/eslint.config.js`

I don't think it's necessary, since the file generated inside the docs is simply called translation-status.json :

translation-status.json

import type { TranslationStatus } from '../../types'
const localesStatuses: TranslationStatus = await import('../../translation-status.json').then(m => m.default)

I have tried to search all the repo to see if elk-translation-status.json was still written somewhere, but I have not found anything.

@userquin
Copy link
Contributor

oh, you're right, you only changed the status file name at root, sorry...

Copy link
Contributor

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@patak-dev patak-dev merged commit 7e20678 into nimbus-town:main Nov 23, 2024
1 check passed
@IonianPlayboy IonianPlayboy deleted the remove-elk-from-config-files branch November 23, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants