Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare bsky #15

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

chore: prepare bsky #15

wants to merge 4 commits into from

Conversation

userquin
Copy link
Contributor

@userquin userquin commented Nov 23, 2024

Added bsky-components folder, when starting the dev server, nuxt will show some warning about duplicated components definitions, you can ignore the warning, components inside bsky-components folder will resolve before the same component inside components folder (check HelpPreview.vue).

The idea is to move the components with the bsky api instead masto, we can comment some parts and later add them back. Once the component is finished, we can keep the original or just remove it from components folder (we can remove components/help/HelpPreview.vue).

We'll need to create the composables/users.ts for bsky (nimbus-users.ts for example, changing some names and using some bsky nomenclature).

Remember to push changes to the branch for this PR: userquin/chore-prepare-bsky.

@userquin userquin marked this pull request as ready for review November 24, 2024 00:03
Copy link
Collaborator

@IonianPlayboy IonianPlayboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The localisation for HelpPreviewneed to be updated as well, but that can definitely be handled in another PR.

bsky-components/help/HelpPreview.vue Outdated Show resolved Hide resolved
bsky-components/help/HelpPreview.vue Outdated Show resolved Hide resolved
bsky-components/help/HelpPreview.vue Outdated Show resolved Hide resolved
userquin and others added 3 commits November 24, 2024 03:16
Co-authored-by: Nathanaël Labreuil <[email protected]>
Co-authored-by: Nathanaël Labreuil <[email protected]>
Co-authored-by: Nathanaël Labreuil <[email protected]>
@patak-dev
Copy link
Contributor

Maybe we could rename the current components to MastoComponents and start with a clean components instead of bsky-components? That will be better for the git history of the project later on.

@patak-dev patak-dev marked this pull request as draft November 24, 2024 06:38
@IonianPlayboy IonianPlayboy added dependencies Pull requests that update a dependency file bluesky parity Feature needed to reach parity with Bluesky labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bluesky parity Feature needed to reach parity with Bluesky dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants