Skip to content

fix: Adopt some more opinionated ruff rules, manual resolutions #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

effigies
Copy link
Member

Follow-up to #492. This is not 100% manual, but it was difficult to separate out the manual from the automatic without parsing out exclusions.

This could stand a review.

Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 86.04651% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.16%. Comparing base (b4a01f6) to head (06b9bab).

Files with missing lines Patch % Lines
sdcflows/workflows/base.py 0.00% 2 Missing ⚠️
sdcflows/cli/parser.py 50.00% 1 Missing ⚠️
sdcflows/interfaces/reportlets.py 50.00% 1 Missing ⚠️
sdcflows/interfaces/utils.py 66.66% 1 Missing ⚠️
sdcflows/workflows/fit/base.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
+ Coverage   84.09%   84.16%   +0.06%     
==========================================
  Files          30       30              
  Lines        2880     2873       -7     
  Branches      374      372       -2     
==========================================
- Hits         2422     2418       -4     
+ Misses        384      381       -3     
  Partials       74       74              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@effigies effigies requested a review from Copilot May 15, 2025 18:52
Copilot

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant