LibWeb: Don't try to wait for HTTP server to exit if kill call fails

nishilshah · Dec 20, 2024 · 9585700 · 9585700
1 parent a450d64
commit 9585700
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/UI/Headless/Fixture.cpp b/UI/Headless/Fixture.cpp
@@ -92,15 +92,11 @@ void HttpEchoServerFixture::teardown_impl()
     if (auto kill_or_error = Core::System::kill(m_process->pid(), SIGINT); kill_or_error.is_error()) {
         if (kill_or_error.error().code() != ESRCH) {
             warnln("Failed to kill HTTP echo server, error: {}", kill_or_error.error());
-            m_process = {};
-            return;
+        } else if (auto termination_or_error = m_process->wait_for_termination(); termination_or_error.is_error()) {
+            warnln("Failed to terminate HTTP echo server, error: {}", termination_or_error.error());
         }
     }
 
-    if (auto termination_or_error = m_process->wait_for_termination(); termination_or_error.is_error()) {
-        warnln("Failed to terminate HTTP echo server, error: {}", termination_or_error.error());
-    }
-
     m_process = {};
 }