Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FluentAPI] Return ICell type for SetXXX methods of ICell interface #1450

Merged
merged 2 commits into from
Nov 26, 2024
Merged

[FluentAPI] Return ICell type for SetXXX methods of ICell interface #1450

merged 2 commits into from
Nov 26, 2024
+103 −76

Conversation

tonyqus
Copy link
Member

@tonyqus tonyqus commented Nov 25, 2024

fix #257

@tonyqus tonyqus added this to the NPOI 2.7.3 milestone Nov 25, 2024
@tonyqus tonyqus changed the title return ICell type for SetXXX methods in ICell Return ICell type for SetXXX methods in ICell Nov 25, 2024
@tonyqus tonyqus self-assigned this Nov 25, 2024
@tonyqus tonyqus requested a review from Bykiev November 25, 2024 20:31
Bykiev
Bykiev approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@Bykiev Bykiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks!

@tonyqus tonyqus changed the title Return ICell type for SetXXX methods in ICell Return ICell type for SetXXX methods of ICell interface Nov 26, 2024
@tonyqus tonyqus merged commit dd1ae35 into nissl-lab:master Nov 26, 2024
3 checks passed
@tonyqus tonyqus changed the title Return ICell type for SetXXX methods of ICell interface [FluentAPI] Return ICell type for SetXXX methods of ICell interface Nov 26, 2024
@tonyqus tonyqus added the api label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bykiev Bykiev Bykiev approved these changes

Assignees

@tonyqus tonyqus

Labels
api enhancement sxssf xls xlsx
Projects
None yet
Milestone
NPOI 2.7.3
Development

Successfully merging this pull request may close these issues.

Fluent API support for ICell
2 participants
@tonyqus @Bykiev